| From 62e96cf81988101fe9e086b2877307b6adda5197 Mon Sep 17 00:00:00 2001 |
| From: Bob Peterson <rpeterso@redhat.com> |
| Date: Mon, 6 Jan 2014 17:16:01 -0500 |
| Subject: GFS2: Increase i_writecount during gfs2_setattr_chown |
| |
| From: Bob Peterson <rpeterso@redhat.com> |
| |
| commit 62e96cf81988101fe9e086b2877307b6adda5197 upstream. |
| |
| This patch calls get_write_access in function gfs2_setattr_chown, |
| which merely increases inode->i_writecount for the duration of the |
| function. That will ensure that any file closes won't delete the |
| inode's multi-block reservation while the function is running. |
| It also ensures that a multi-block reservation exists when needed |
| for quota change operations during the chown. |
| |
| Signed-off-by: Bob Peterson <rpeterso@redhat.com> |
| Signed-off-by: Steven Whitehouse <swhiteho@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/gfs2/inode.c | 16 +++++++++++++++- |
| 1 file changed, 15 insertions(+), 1 deletion(-) |
| |
| --- a/fs/gfs2/inode.c |
| +++ b/fs/gfs2/inode.c |
| @@ -1610,10 +1610,22 @@ static int setattr_chown(struct inode *i |
| if (!(attr->ia_valid & ATTR_GID) || gid_eq(ogid, ngid)) |
| ogid = ngid = NO_GID_QUOTA_CHANGE; |
| |
| - error = gfs2_quota_lock(ip, nuid, ngid); |
| + error = get_write_access(inode); |
| if (error) |
| return error; |
| |
| + error = gfs2_rs_alloc(ip); |
| + if (error) |
| + goto out; |
| + |
| + error = gfs2_rindex_update(sdp); |
| + if (error) |
| + goto out; |
| + |
| + error = gfs2_quota_lock(ip, nuid, ngid); |
| + if (error) |
| + goto out; |
| + |
| if (!uid_eq(ouid, NO_UID_QUOTA_CHANGE) || |
| !gid_eq(ogid, NO_GID_QUOTA_CHANGE)) { |
| error = gfs2_quota_check(ip, nuid, ngid); |
| @@ -1640,6 +1652,8 @@ out_end_trans: |
| gfs2_trans_end(sdp); |
| out_gunlock_q: |
| gfs2_quota_unlock(ip); |
| +out: |
| + put_write_access(inode); |
| return error; |
| } |
| |