| From foo@baz Wed May 28 21:03:54 PDT 2014 |
| From: Peter Christensen <pch@ordbogen.com> |
| Date: Thu, 8 May 2014 11:15:37 +0200 |
| Subject: macvlan: Don't propagate IFF_ALLMULTI changes on down |
| interfaces. |
| |
| From: Peter Christensen <pch@ordbogen.com> |
| |
| [ Upstream commit bbeb0eadcf9fe74fb2b9b1a6fea82cd538b1e556 ] |
| |
| Clearing the IFF_ALLMULTI flag on a down interface could cause an allmulti |
| overflow on the underlying interface. |
| |
| Attempting the set IFF_ALLMULTI on the underlying interface would cause an |
| error and the log message: |
| |
| "allmulti touches root, set allmulti failed." |
| |
| Signed-off-by: Peter Christensen <pch@ordbogen.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/macvlan.c | 6 ++++-- |
| 1 file changed, 4 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/net/macvlan.c |
| +++ b/drivers/net/macvlan.c |
| @@ -458,8 +458,10 @@ static void macvlan_change_rx_flags(stru |
| struct macvlan_dev *vlan = netdev_priv(dev); |
| struct net_device *lowerdev = vlan->lowerdev; |
| |
| - if (change & IFF_ALLMULTI) |
| - dev_set_allmulti(lowerdev, dev->flags & IFF_ALLMULTI ? 1 : -1); |
| + if (dev->flags & IFF_UP) { |
| + if (change & IFF_ALLMULTI) |
| + dev_set_allmulti(lowerdev, dev->flags & IFF_ALLMULTI ? 1 : -1); |
| + } |
| } |
| |
| static void macvlan_set_mac_lists(struct net_device *dev) |
