| From 317168d0c766defd14b3d0e9c2c4a9a258b803ee Mon Sep 17 00:00:00 2001 |
| From: Takashi Iwai <tiwai@suse.de> |
| Date: Tue, 28 Oct 2014 12:42:19 +0100 |
| Subject: ALSA: pcm: Zero-clear reserved fields of PCM status ioctl in compat mode |
| |
| From: Takashi Iwai <tiwai@suse.de> |
| |
| commit 317168d0c766defd14b3d0e9c2c4a9a258b803ee upstream. |
| |
| In compat mode, we copy each field of snd_pcm_status struct but don't |
| touch the reserved fields, and this leaves uninitialized values |
| there. Meanwhile the native ioctl does zero-clear the whole |
| structure, so we should follow the same rule in compat mode, too. |
| |
| Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| sound/core/pcm_compat.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/sound/core/pcm_compat.c |
| +++ b/sound/core/pcm_compat.c |
| @@ -210,6 +210,8 @@ static int snd_pcm_status_user_compat(st |
| if (err < 0) |
| return err; |
| |
| + if (clear_user(src, sizeof(*src))) |
| + return -EFAULT; |
| if (put_user(status.state, &src->state) || |
| compat_put_timespec(&status.trigger_tstamp, &src->trigger_tstamp) || |
| compat_put_timespec(&status.tstamp, &src->tstamp) || |
