| From 599a9b77ab289d85c2d5c8607624efbe1f552b0f Mon Sep 17 00:00:00 2001 |
| From: Jan Kara <jack@suse.cz> |
| Date: Thu, 30 Oct 2014 10:53:16 -0400 |
| Subject: ext4: fix oops when loading block bitmap failed |
| |
| From: Jan Kara <jack@suse.cz> |
| |
| commit 599a9b77ab289d85c2d5c8607624efbe1f552b0f upstream. |
| |
| When we fail to load block bitmap in __ext4_new_inode() we will |
| dereference NULL pointer in ext4_journal_get_write_access(). So check |
| for error from ext4_read_block_bitmap(). |
| |
| Coverity-id: 989065 |
| Signed-off-by: Jan Kara <jack@suse.cz> |
| Signed-off-by: Theodore Ts'o <tytso@mit.edu> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/ext4/ialloc.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| --- a/fs/ext4/ialloc.c |
| +++ b/fs/ext4/ialloc.c |
| @@ -887,6 +887,10 @@ got: |
| struct buffer_head *block_bitmap_bh; |
| |
| block_bitmap_bh = ext4_read_block_bitmap(sb, group); |
| + if (!block_bitmap_bh) { |
| + err = -EIO; |
| + goto out; |
| + } |
| BUFFER_TRACE(block_bitmap_bh, "get block bitmap access"); |
| err = ext4_journal_get_write_access(handle, block_bitmap_bh); |
| if (err) { |
