| From 474d2605d119479e5aa050f738632e63589d4bb5 Mon Sep 17 00:00:00 2001 |
| From: Jan Kara <jack@suse.cz> |
| Date: Wed, 22 Oct 2014 09:06:49 +0200 |
| Subject: quota: Properly return errors from dquot_writeback_dquots() |
| |
| From: Jan Kara <jack@suse.cz> |
| |
| commit 474d2605d119479e5aa050f738632e63589d4bb5 upstream. |
| |
| Due to a switched left and right side of an assignment, |
| dquot_writeback_dquots() never returned error. This could result in |
| errors during quota writeback to not be reported to userspace properly. |
| Fix it. |
| |
| Coverity-id: 1226884 |
| Signed-off-by: Jan Kara <jack@suse.cz> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/quota/dquot.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/quota/dquot.c |
| +++ b/fs/quota/dquot.c |
| @@ -634,7 +634,7 @@ int dquot_writeback_dquots(struct super_ |
| dqstats_inc(DQST_LOOKUPS); |
| err = sb->dq_op->write_dquot(dquot); |
| if (!ret && err) |
| - err = ret; |
| + ret = err; |
| dqput(dquot); |
| spin_lock(&dq_list_lock); |
| } |
