| From 1823342a1f2b47a4e6f5667f67cd28ab6bc4d6cd Mon Sep 17 00:00:00 2001 |
| From: Guenter Roeck <linux@roeck-us.net> |
| Date: Sun, 1 Jul 2018 13:56:54 -0700 |
| Subject: configfs: replace strncpy with memcpy |
| |
| From: Guenter Roeck <linux@roeck-us.net> |
| |
| commit 1823342a1f2b47a4e6f5667f67cd28ab6bc4d6cd upstream. |
| |
| gcc 8.1.0 complains: |
| |
| fs/configfs/symlink.c:67:3: warning: |
| 'strncpy' output truncated before terminating nul copying as many |
| bytes from a string as its length |
| fs/configfs/symlink.c: In function 'configfs_get_link': |
| fs/configfs/symlink.c:63:13: note: length computed here |
| |
| Using strncpy() is indeed less than perfect since the length of data to |
| be copied has already been determined with strlen(). Replace strncpy() |
| with memcpy() to address the warning and optimize the code a little. |
| |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Christoph Hellwig <hch@lst.de> |
| Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu@cybertrust.co.jp> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/configfs/symlink.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/configfs/symlink.c |
| +++ b/fs/configfs/symlink.c |
| @@ -64,7 +64,7 @@ static void fill_item_path(struct config |
| |
| /* back up enough to print this bus id with '/' */ |
| length -= cur; |
| - strncpy(buffer + length,config_item_name(p),cur); |
| + memcpy(buffer + length, config_item_name(p), cur); |
| *(buffer + --length) = '/'; |
| } |
| } |