| From 62be73eafaa045d3233337303fb140f7f8a61135 Mon Sep 17 00:00:00 2001 |
| From: Seiji Aguchi <seiji.aguchi@hds.com> |
| Date: Tue, 15 May 2012 17:35:09 -0400 |
| Subject: kdump: Execute kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop() |
| |
| From: Seiji Aguchi <seiji.aguchi@hds.com> |
| |
| commit 62be73eafaa045d3233337303fb140f7f8a61135 upstream. |
| |
| This patch moves kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop(), |
| to serialize the crash-logging process via smp_send_stop() and to |
| thus retrieve a more stable crash image of all CPUs stopped. |
| |
| Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com> |
| Acked-by: Don Zickus <dzickus@redhat.com> |
| Cc: dle-develop@lists.sourceforge.net <dle-develop@lists.sourceforge.net> |
| Cc: Satoru Moriya <satoru.moriya@hds.com> |
| Cc: Tony Luck <tony.luck@intel.com> |
| Cc: a.p.zijlstra@chello.nl <a.p.zijlstra@chello.nl> |
| Link: http://lkml.kernel.org/r/5C4C569E8A4B9B42A84A977CF070A35B2E4D7A5CE2@USINDEVS01.corp.hds.com |
| Signed-off-by: Ingo Molnar <mingo@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| kernel/panic.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/kernel/panic.c |
| +++ b/kernel/panic.c |
| @@ -108,8 +108,6 @@ void panic(const char *fmt, ...) |
| */ |
| crash_kexec(NULL); |
| |
| - kmsg_dump(KMSG_DUMP_PANIC); |
| - |
| /* |
| * Note smp_send_stop is the usual smp shutdown function, which |
| * unfortunately means it may not be hardened to work in a panic |
| @@ -117,6 +115,8 @@ void panic(const char *fmt, ...) |
| */ |
| smp_send_stop(); |
| |
| + kmsg_dump(KMSG_DUMP_PANIC); |
| + |
| atomic_notifier_call_chain(&panic_notifier_list, 0, buf); |
| |
| bust_spinlocks(0); |