| From 53d3b4d7778daf15900867336c85d3f8dd70600c Mon Sep 17 00:00:00 2001 |
| From: Egbert Eich <eich@suse.de> |
| Date: Tue, 4 Jun 2013 17:13:21 +0200 |
| Subject: drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for DDC. |
| |
| From: Egbert Eich <eich@suse.de> |
| |
| commit 53d3b4d7778daf15900867336c85d3f8dd70600c upstream. |
| |
| In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used |
| for DDC. Thus the code will always have to rely on a LVDS panel |
| mode supplied by VBT. |
| In most cases this succeeds, so this didn't get detected for quite |
| a while. |
| |
| This regression seems to have been introduced in |
| |
| commit f899fc64cda8569d0529452aafc0da31c042df2e |
| Author: Chris Wilson <chris@chris-wilson.co.uk> |
| Date: Tue Jul 20 15:44:45 2010 -0700 |
| |
| drm/i915: use GMBUS to manage i2c links |
| |
| Signed-off-by: Egbert Eich <eich@suse.de> |
| Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> |
| [danvet: Add note about which commit likely introduced this issue.] |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/gpu/drm/i915/intel_sdvo.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/gpu/drm/i915/intel_sdvo.c |
| +++ b/drivers/gpu/drm/i915/intel_sdvo.c |
| @@ -1770,7 +1770,7 @@ static void intel_sdvo_get_lvds_modes(st |
| * Assume that the preferred modes are |
| * arranged in priority order. |
| */ |
| - intel_ddc_get_modes(connector, intel_sdvo->i2c); |
| + intel_ddc_get_modes(connector, &intel_sdvo->ddc); |
| if (list_empty(&connector->probed_modes) == false) |
| goto end; |
| |