| From foo@baz Thu May 24 10:12:00 CEST 2018 |
| From: James Smart <jsmart2021@gmail.com> |
| Date: Tue, 30 Jan 2018 15:58:55 -0800 |
| Subject: scsi: lpfc: Fix issue_lip if link is disabled |
| |
| From: James Smart <jsmart2021@gmail.com> |
| |
| [ Upstream commit 2289e9598dde9705400559ca2606fb8c145c34f0 ] |
| |
| The driver ignored checks on whether the link should be kept |
| administratively down after a link bounce. Correct the checks. |
| |
| Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com> |
| Signed-off-by: James Smart <james.smart@broadcom.com> |
| Reviewed-by: Hannes Reinecke <hare@suse.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/scsi/lpfc/lpfc_attr.c | 5 +++++ |
| 1 file changed, 5 insertions(+) |
| |
| --- a/drivers/scsi/lpfc/lpfc_attr.c |
| +++ b/drivers/scsi/lpfc/lpfc_attr.c |
| @@ -905,7 +905,12 @@ lpfc_issue_lip(struct Scsi_Host *shost) |
| LPFC_MBOXQ_t *pmboxq; |
| int mbxstatus = MBXERR_ERROR; |
| |
| + /* |
| + * If the link is offline, disabled or BLOCK_MGMT_IO |
| + * it doesn't make any sense to allow issue_lip |
| + */ |
| if ((vport->fc_flag & FC_OFFLINE_MODE) || |
| + (phba->hba_flag & LINK_DISABLED) || |
| (phba->sli.sli_flag & LPFC_BLOCK_MGMT_IO)) |
| return -EPERM; |
| |