| From foo@baz Sun Jun 17 12:07:34 CEST 2018 |
| From: Mathieu Malaterre <malat@debian.org> |
| Date: Sat, 5 May 2018 22:00:37 +0200 |
| Subject: driver core: add __printf verification to __ata_ehi_pushv_desc |
| |
| From: Mathieu Malaterre <malat@debian.org> |
| |
| [ Upstream commit 0d74d872c3f8b9cb3d096fb932a063b43b37f188 ] |
| |
| __printf is useful to verify format and arguments. Remove the following |
| warning (with W=1): |
| |
| drivers/ata/libata-eh.c:183:10: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] |
| |
| Signed-off-by: Mathieu Malaterre <malat@debian.org> |
| Signed-off-by: Tejun Heo <tj@kernel.org> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/ata/libata-eh.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/ata/libata-eh.c |
| +++ b/drivers/ata/libata-eh.c |
| @@ -175,8 +175,8 @@ static void ata_eh_handle_port_resume(st |
| { } |
| #endif /* CONFIG_PM */ |
| |
| -static void __ata_ehi_pushv_desc(struct ata_eh_info *ehi, const char *fmt, |
| - va_list args) |
| +static __printf(2, 0) void __ata_ehi_pushv_desc(struct ata_eh_info *ehi, |
| + const char *fmt, va_list args) |
| { |
| ehi->desc_len += vscnprintf(ehi->desc + ehi->desc_len, |
| ATA_EH_DESC_LEN - ehi->desc_len, |