| From foo@baz Sun Jun 17 12:07:33 CEST 2018 |
| From: Arvind Yadav <arvind.yadav.cs@gmail.com> |
| Date: Tue, 24 Apr 2018 13:33:03 +0530 |
| Subject: HID: wacom: Release device resource data obtained by devres_alloc() |
| |
| From: Arvind Yadav <arvind.yadav.cs@gmail.com> |
| |
| [ Upstream commit 097b8f62dd793e08f1732fc74dbb64596c7fbff9 ] |
| |
| Free device resource data, if __wacom_devm_sysfs_create_group |
| is not successful. |
| |
| Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> |
| Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> |
| Signed-off-by: Jiri Kosina <jkosina@suse.cz> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/hid/wacom_sys.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/hid/wacom_sys.c |
| +++ b/drivers/hid/wacom_sys.c |
| @@ -1213,8 +1213,10 @@ static int __wacom_devm_sysfs_create_gro |
| devres->root = root; |
| |
| error = sysfs_create_group(devres->root, group); |
| - if (error) |
| + if (error) { |
| + devres_free(devres); |
| return error; |
| + } |
| |
| devres_add(&wacom->hdev->dev, devres); |
| |
