| From d68b1ad051fbf138a6636e1ad66952690875ad31 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 27 Jul 2020 12:25:28 -0400 |
| Subject: selftests/net: rxtimestamp: fix clang issues for target arch PowerPC |
| |
| From: Tanner Love <tannerlove@google.com> |
| |
| [ Upstream commit 955cbe91bcf782c09afe369c95a20f0a4b6dcc3c ] |
| |
| The signedness of char is implementation-dependent. Some systems |
| (including PowerPC and ARM) use unsigned char. Clang 9 threw: |
| warning: result of comparison of constant -1 with expression of type \ |
| 'char' is always true [-Wtautological-constant-out-of-range-compare] |
| &arg_index)) != -1) { |
| |
| Tested: make -C tools/testing/selftests TARGETS="net" run_tests |
| |
| Fixes: 16e781224198 ("selftests/net: Add a test to validate behavior of rx timestamps") |
| Signed-off-by: Tanner Love <tannerlove@google.com> |
| Acked-by: Willem de Bruijn <willemb@google.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/testing/selftests/networking/timestamping/rxtimestamp.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| diff --git a/tools/testing/selftests/networking/timestamping/rxtimestamp.c b/tools/testing/selftests/networking/timestamping/rxtimestamp.c |
| index 7a573fb4c1c4e..c6428f1ac22fb 100644 |
| --- a/tools/testing/selftests/networking/timestamping/rxtimestamp.c |
| +++ b/tools/testing/selftests/networking/timestamping/rxtimestamp.c |
| @@ -328,8 +328,7 @@ int main(int argc, char **argv) |
| bool all_tests = true; |
| int arg_index = 0; |
| int failures = 0; |
| - int s, t; |
| - char opt; |
| + int s, t, opt; |
| |
| while ((opt = getopt_long(argc, argv, "", long_options, |
| &arg_index)) != -1) { |
| -- |
| 2.25.1 |
| |
