| From df997abeebadaa4824271009e2d2b526a70a11cb Mon Sep 17 00:00:00 2001 |
| From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
| Date: Mon, 11 Feb 2019 12:43:23 -0600 |
| Subject: iscsi_ibft: Fix missing break in switch statement |
| |
| From: Gustavo A. R. Silva <gustavo@embeddedor.com> |
| |
| commit df997abeebadaa4824271009e2d2b526a70a11cb upstream. |
| |
| Add missing break statement in order to prevent the code from falling |
| through to case ISCSI_BOOT_TGT_NAME, which is unnecessary. |
| |
| This bug was found thanks to the ongoing efforts to enable |
| -Wimplicit-fallthrough. |
| |
| Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib") |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> |
| Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/firmware/iscsi_ibft.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/firmware/iscsi_ibft.c |
| +++ b/drivers/firmware/iscsi_ibft.c |
| @@ -542,6 +542,7 @@ static umode_t __init ibft_check_tgt_for |
| case ISCSI_BOOT_TGT_NIC_ASSOC: |
| case ISCSI_BOOT_TGT_CHAP_TYPE: |
| rc = S_IRUGO; |
| + break; |
| case ISCSI_BOOT_TGT_NAME: |
| if (tgt->tgt_name_len) |
| rc = S_IRUGO; |
