| From 33bd4df99f4f4c8d421d7420d9b49310930a7c83 Mon Sep 17 00:00:00 2001 |
| From: Yonglong Liu <liuyonglong@huawei.com> |
| Date: Sat, 26 Jan 2019 17:18:27 +0800 |
| Subject: net: hns: Fix wrong read accesses via Clause 45 MDIO protocol |
| |
| [ Upstream commit cec8abba13e6a26729dfed41019720068eeeff2b ] |
| |
| When reading phy registers via Clause 45 MDIO protocol, after write |
| address operation, the driver use another write address operation, so |
| can not read the right value of any phy registers. This patch fixes it. |
| |
| Signed-off-by: Yonglong Liu <liuyonglong@huawei.com> |
| Signed-off-by: Peng Li <lipeng321@huawei.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c |
| index 017e08452d8c..baf5cc251f32 100644 |
| --- a/drivers/net/ethernet/hisilicon/hns_mdio.c |
| +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c |
| @@ -321,7 +321,7 @@ static int hns_mdio_read(struct mii_bus *bus, int phy_id, int regnum) |
| } |
| |
| hns_mdio_cmd_write(mdio_dev, is_c45, |
| - MDIO_C45_WRITE_ADDR, phy_id, devad); |
| + MDIO_C45_READ, phy_id, devad); |
| } |
| |
| /* Step 5: waitting for MDIO_COMMAND_REG 's mdio_start==0,*/ |
| -- |
| 2.19.1 |
| |