| From 030e2c78d3a91dd0d27fef37e91950dde333eba1 Mon Sep 17 00:00:00 2001 |
| From: Takashi Iwai <tiwai@suse.de> |
| Date: Tue, 12 Jan 2016 12:38:02 +0100 |
| Subject: ALSA: seq: Fix missing NULL check at remove_events ioctl |
| |
| From: Takashi Iwai <tiwai@suse.de> |
| |
| commit 030e2c78d3a91dd0d27fef37e91950dde333eba1 upstream. |
| |
| snd_seq_ioctl_remove_events() calls snd_seq_fifo_clear() |
| unconditionally even if there is no FIFO assigned, and this leads to |
| an Oops due to NULL dereference. The fix is just to add a proper NULL |
| check. |
| |
| Reported-by: Dmitry Vyukov <dvyukov@google.com> |
| Tested-by: Dmitry Vyukov <dvyukov@google.com> |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| sound/core/seq/seq_clientmgr.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/sound/core/seq/seq_clientmgr.c |
| +++ b/sound/core/seq/seq_clientmgr.c |
| @@ -1962,7 +1962,7 @@ static int snd_seq_ioctl_remove_events(s |
| * No restrictions so for a user client we can clear |
| * the whole fifo |
| */ |
| - if (client->type == USER_CLIENT) |
| + if (client->type == USER_CLIENT && client->data.user.fifo) |
| snd_seq_fifo_clear(client->data.user.fifo); |
| } |
| |
