| From abdc9a3b4bac97add99e1d77dc6d28623afe682b Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Wed, 16 Dec 2015 14:06:37 +0300 |
| Subject: USB: ipaq.c: fix a timeout loop |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit abdc9a3b4bac97add99e1d77dc6d28623afe682b upstream. |
| |
| The code expects the loop to end with "retries" set to zero but, because |
| it is a post-op, it will end set to -1. I have fixed this by moving the |
| decrement inside the loop. |
| |
| Fixes: 014aa2a3c32e ('USB: ipaq: minor ipaq_open() cleanup.') |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/serial/ipaq.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/usb/serial/ipaq.c |
| +++ b/drivers/usb/serial/ipaq.c |
| @@ -531,7 +531,8 @@ static int ipaq_open(struct tty_struct * |
| * through. Since this has a reasonably high failure rate, we retry |
| * several times. |
| */ |
| - while (retries--) { |
| + while (retries) { |
| + retries--; |
| result = usb_control_msg(serial->dev, |
| usb_sndctrlpipe(serial->dev, 0), 0x22, 0x21, |
| 0x1, 0, NULL, 0, 100); |