| From 68a18ad71378a56858141c4449e02a30c829763e Mon Sep 17 00:00:00 2001 |
| From: Tom Rix <trix@redhat.com> |
| Date: Thu, 23 Dec 2021 08:28:48 -0800 |
| Subject: mac80211: initialize variable have_higher_than_11mbit |
| |
| From: Tom Rix <trix@redhat.com> |
| |
| commit 68a18ad71378a56858141c4449e02a30c829763e upstream. |
| |
| Clang static analysis reports this warnings |
| |
| mlme.c:5332:7: warning: Branch condition evaluates to a |
| garbage value |
| have_higher_than_11mbit) |
| ^~~~~~~~~~~~~~~~~~~~~~~ |
| |
| have_higher_than_11mbit is only set to true some of the time in |
| ieee80211_get_rates() but is checked all of the time. So |
| have_higher_than_11mbit needs to be initialized to false. |
| |
| Fixes: 5d6a1b069b7f ("mac80211: set basic rates earlier") |
| Signed-off-by: Tom Rix <trix@redhat.com> |
| Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> |
| Link: https://lore.kernel.org/r/20211223162848.3243702-1-trix@redhat.com |
| Signed-off-by: Johannes Berg <johannes.berg@intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/mac80211/mlme.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/mac80211/mlme.c |
| +++ b/net/mac80211/mlme.c |
| @@ -4431,7 +4431,7 @@ static int ieee80211_prep_connection(str |
| |
| if (new_sta) { |
| u32 rates = 0, basic_rates = 0; |
| - bool have_higher_than_11mbit; |
| + bool have_higher_than_11mbit = false; |
| int min_rate = INT_MAX, min_rate_index = -1; |
| struct ieee80211_chanctx_conf *chanctx_conf; |
| const struct cfg80211_bss_ies *ies; |