| From 9d746ab68163d642dae13756b2b3145b2e38cb65 Mon Sep 17 00:00:00 2001 |
| From: Mario Kleiner <mario.kleiner.de@gmail.com> |
| Date: Tue, 24 May 2016 18:12:43 +0200 |
| Subject: drm/amdgpu: Fix hdmi deep color support. |
| |
| From: Mario Kleiner <mario.kleiner.de@gmail.com> |
| |
| commit 9d746ab68163d642dae13756b2b3145b2e38cb65 upstream. |
| |
| When porting the hdmi deep color detection code from |
| radeon-kms to amdgpu-kms apparently some kind of |
| copy and paste error happened, attaching an else |
| branch to the wrong if statement. |
| |
| The result is that hdmi deep color mode is always |
| disabled, regardless of gpu and display capabilities and |
| user wishes, as the code mistakenly thinks that the display |
| doesn't provide the required max_tmds_clock limit and falls |
| back to 8 bpc. |
| |
| This patch fixes deep color support, as tested on a |
| R9 380 Tonga Pro + suitable display, and should be |
| backported to all kernels with amdgpu-kms support. |
| |
| Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com> |
| Cc: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 10 +++++----- |
| 1 file changed, 5 insertions(+), 5 deletions(-) |
| |
| --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c |
| +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c |
| @@ -194,12 +194,12 @@ int amdgpu_connector_get_monitor_bpc(str |
| bpc = 8; |
| DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using %d bpc.\n", |
| connector->name, bpc); |
| - } else if (bpc > 8) { |
| - /* max_tmds_clock missing, but hdmi spec mandates it for deep color. */ |
| - DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing. Using 8 bpc.\n", |
| - connector->name); |
| - bpc = 8; |
| } |
| + } else if (bpc > 8) { |
| + /* max_tmds_clock missing, but hdmi spec mandates it for deep color. */ |
| + DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing. Using 8 bpc.\n", |
| + connector->name); |
| + bpc = 8; |
| } |
| } |
| |