| From 19ced623db2fe91604d69f7d86b03144c5107739 Mon Sep 17 00:00:00 2001 |
| From: Linus Walleij <linus.walleij@linaro.org> |
| Date: Wed, 8 Jun 2016 14:56:39 +0200 |
| Subject: crypto: ux500 - memmove the right size |
| |
| From: Linus Walleij <linus.walleij@linaro.org> |
| |
| commit 19ced623db2fe91604d69f7d86b03144c5107739 upstream. |
| |
| The hash buffer is really HASH_BLOCK_SIZE bytes, someone |
| must have thought that memmove takes n*u32 words by mistake. |
| Tests work as good/bad as before after this patch. |
| |
| Cc: Joakim Bech <joakim.bech@linaro.org> |
| Reported-by: David Binderman <linuxdev.baldrick@gmail.com> |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/crypto/ux500/hash/hash_core.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/crypto/ux500/hash/hash_core.c |
| +++ b/drivers/crypto/ux500/hash/hash_core.c |
| @@ -781,7 +781,7 @@ static int hash_process_data(struct hash |
| &device_data->state); |
| memmove(req_ctx->state.buffer, |
| device_data->state.buffer, |
| - HASH_BLOCK_SIZE / sizeof(u32)); |
| + HASH_BLOCK_SIZE); |
| if (ret) { |
| dev_err(device_data->dev, |
| "%s: hash_resume_state() failed!\n", |
| @@ -832,7 +832,7 @@ static int hash_process_data(struct hash |
| |
| memmove(device_data->state.buffer, |
| req_ctx->state.buffer, |
| - HASH_BLOCK_SIZE / sizeof(u32)); |
| + HASH_BLOCK_SIZE); |
| if (ret) { |
| dev_err(device_data->dev, "%s: hash_save_state() failed!\n", |
| __func__); |