| From 593224ea77b1ca842f45cf76f4deeef44dfbacd1 Mon Sep 17 00:00:00 2001 |
| From: Hans de Goede <hdegoede@redhat.com> |
| Date: Tue, 31 May 2016 09:18:03 +0200 |
| Subject: USB: uas: Fix slave queue_depth not being set |
| |
| From: Hans de Goede <hdegoede@redhat.com> |
| |
| commit 593224ea77b1ca842f45cf76f4deeef44dfbacd1 upstream. |
| |
| Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") |
| removed the scsi_change_queue_depth() call from uas_slave_configure() |
| assuming that the slave would inherit the host's queue_depth, which |
| that commit sets to the same value. |
| |
| This is incorrect, without the scsi_change_queue_depth() call the slave's |
| queue_depth defaults to 1, introducing a performance regression. |
| |
| This commit restores the call, fixing the performance regression. |
| |
| Fixes: 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") |
| Reported-by: Tom Yan <tom.ty89@gmail.com> |
| Signed-off-by: Hans de Goede <hdegoede@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/storage/uas.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/usb/storage/uas.c |
| +++ b/drivers/usb/storage/uas.c |
| @@ -835,6 +835,7 @@ static int uas_slave_configure(struct sc |
| if (devinfo->flags & US_FL_BROKEN_FUA) |
| sdev->broken_fua = 1; |
| |
| + scsi_change_queue_depth(sdev, devinfo->qdepth - 2); |
| return 0; |
| } |
| |
