| From 2fe2f378dd45847d2643638c07a7658822087836 Mon Sep 17 00:00:00 2001 |
| From: Bart Van Assche <bart.vanassche@sandisk.com> |
| Date: Mon, 21 Nov 2016 10:21:17 -0800 |
| Subject: IB/mad: Fix an array index check |
| |
| From: Bart Van Assche <bart.vanassche@sandisk.com> |
| |
| commit 2fe2f378dd45847d2643638c07a7658822087836 upstream. |
| |
| The array ib_mad_mgmt_class_table.method_table has MAX_MGMT_CLASS |
| (80) elements. Hence compare the array index with that value instead |
| of with IB_MGMT_MAX_METHODS (128). This patch avoids that Coverity |
| reports the following: |
| |
| Overrunning array class->method_table of 80 8-byte elements at element index 127 (byte offset 1016) using index convert_mgmt_class(mad_hdr->mgmt_class) (which evaluates to 127). |
| |
| Fixes: commit b7ab0b19a85f ("IB/mad: Verify mgmt class in received MADs") |
| Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> |
| Cc: Sean Hefty <sean.hefty@intel.com> |
| Reviewed-by: Hal Rosenstock <hal@mellanox.com> |
| Signed-off-by: Doug Ledford <dledford@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/infiniband/core/mad.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/infiniband/core/mad.c |
| +++ b/drivers/infiniband/core/mad.c |
| @@ -1746,7 +1746,7 @@ find_mad_agent(struct ib_mad_port_privat |
| if (!class) |
| goto out; |
| if (convert_mgmt_class(mad_hdr->mgmt_class) >= |
| - IB_MGMT_MAX_METHODS) |
| + ARRAY_SIZE(class->method_table)) |
| goto out; |
| method = class->method_table[convert_mgmt_class( |
| mad_hdr->mgmt_class)]; |
