| From 11b642b84e8c43e8597de031678d15c08dd057bc Mon Sep 17 00:00:00 2001 |
| From: Bart Van Assche <bart.vanassche@sandisk.com> |
| Date: Mon, 21 Nov 2016 10:21:41 -0800 |
| Subject: IPoIB: Avoid reading an uninitialized member variable |
| |
| From: Bart Van Assche <bart.vanassche@sandisk.com> |
| |
| commit 11b642b84e8c43e8597de031678d15c08dd057bc upstream. |
| |
| This patch avoids that Coverity reports the following: |
| |
| Using uninitialized value port_attr.state when calling printk |
| |
| Fixes: commit 94232d9ce817 ("IPoIB: Start multicast join process only on active ports") |
| Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> |
| Cc: Erez Shitrit <erezsh@mellanox.com> |
| Reviewed-by: Leon Romanovsky <leonro@mellanox.com> |
| Signed-off-by: Doug Ledford <dledford@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 7 +++++-- |
| 1 file changed, 5 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c |
| +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c |
| @@ -575,8 +575,11 @@ void ipoib_mcast_join_task(struct work_s |
| if (!test_bit(IPOIB_FLAG_OPER_UP, &priv->flags)) |
| return; |
| |
| - if (ib_query_port(priv->ca, priv->port, &port_attr) || |
| - port_attr.state != IB_PORT_ACTIVE) { |
| + if (ib_query_port(priv->ca, priv->port, &port_attr)) { |
| + ipoib_dbg(priv, "ib_query_port() failed\n"); |
| + return; |
| + } |
| + if (port_attr.state != IB_PORT_ACTIVE) { |
| ipoib_dbg(priv, "port state is not ACTIVE (state = %d) suspending join task\n", |
| port_attr.state); |
| return; |