| From 8052d7245b6089992343c80b38b14dbbd8354651 Mon Sep 17 00:00:00 2001 |
| From: Larry Finger <Larry.Finger@lwfinger.net> |
| Date: Sat, 5 Nov 2016 14:08:57 -0500 |
| Subject: ssb: Fix error routine when fallback SPROM fails |
| |
| From: Larry Finger <Larry.Finger@lwfinger.net> |
| |
| commit 8052d7245b6089992343c80b38b14dbbd8354651 upstream. |
| |
| When there is a CRC error in the SPROM read from the device, the code |
| attempts to handle a fallback SPROM. When this also fails, the driver |
| returns zero rather than an error code. |
| |
| Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/ssb/pci.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/ssb/pci.c |
| +++ b/drivers/ssb/pci.c |
| @@ -909,6 +909,7 @@ static int ssb_pci_sprom_get(struct ssb_ |
| if (err) { |
| ssb_warn("WARNING: Using fallback SPROM failed (err %d)\n", |
| err); |
| + goto out_free; |
| } else { |
| ssb_dbg("Using SPROM revision %d provided by platform\n", |
| sprom->revision); |