| From 9236edc16bee49b0dfea6270e5464104c516d144 Mon Sep 17 00:00:00 2001 |
| From: Alaa Hleihel <alaa@mellanox.com> |
| Date: Tue, 13 Feb 2018 12:18:27 +0200 |
| Subject: IB/ipoib: Do not warn if IPoIB debugfs doesn't exist |
| |
| [ Upstream commit 14fa91e0fef8e4d6feb8b1fa2a807828e0abe815 ] |
| |
| netdev_wait_allrefs() could rebroadcast NETDEV_UNREGISTER event |
| multiple times until all refs are gone, which will result in calling |
| ipoib_delete_debug_files multiple times and printing a warning. |
| |
| Remove the WARN_ONCE since checks of NULL pointers before calling |
| debugfs_remove are not needed. |
| |
| Fixes: 771a52584096 ("IB/IPoIB: ibX: failed to create mcg debug file") |
| Signed-off-by: Alaa Hleihel <alaa@mellanox.com> |
| Signed-off-by: Leon Romanovsky <leon@kernel.org> |
| Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com> |
| Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/infiniband/ulp/ipoib/ipoib_fs.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| diff --git a/drivers/infiniband/ulp/ipoib/ipoib_fs.c b/drivers/infiniband/ulp/ipoib/ipoib_fs.c |
| index 09396bd7b02d..63be3bcdc0e3 100644 |
| --- a/drivers/infiniband/ulp/ipoib/ipoib_fs.c |
| +++ b/drivers/infiniband/ulp/ipoib/ipoib_fs.c |
| @@ -281,8 +281,6 @@ void ipoib_delete_debug_files(struct net_device *dev) |
| { |
| struct ipoib_dev_priv *priv = netdev_priv(dev); |
| |
| - WARN_ONCE(!priv->mcg_dentry, "null mcg debug file\n"); |
| - WARN_ONCE(!priv->path_dentry, "null path debug file\n"); |
| debugfs_remove(priv->mcg_dentry); |
| debugfs_remove(priv->path_dentry); |
| priv->mcg_dentry = priv->path_dentry = NULL; |
| -- |
| 2.17.1 |
| |
