| From 02673f18ad1d162eec032c9543d74d0ec73fc683 Mon Sep 17 00:00:00 2001 |
| From: Sabrina Dubroca <sd@queasysnail.net> |
| Date: Tue, 10 Oct 2017 17:07:12 +0200 |
| Subject: macsec: fix memory leaks when skb_to_sgvec fails |
| |
| [ Upstream commit 5aba2ba5030b66a6f8c93049b718556f9aacd7c6 ] |
| |
| Fixes: cda7ea690350 ("macsec: check return value of skb_to_sgvec always") |
| Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/macsec.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c |
| index 365a48cfcbbf..653f0b185a68 100644 |
| --- a/drivers/net/macsec.c |
| +++ b/drivers/net/macsec.c |
| @@ -744,6 +744,7 @@ static struct sk_buff *macsec_encrypt(struct sk_buff *skb, |
| sg_init_table(sg, ret); |
| ret = skb_to_sgvec(skb, sg, 0, skb->len); |
| if (unlikely(ret < 0)) { |
| + aead_request_free(req); |
| macsec_txsa_put(tx_sa); |
| kfree_skb(skb); |
| return ERR_PTR(ret); |
| @@ -956,6 +957,7 @@ static struct sk_buff *macsec_decrypt(struct sk_buff *skb, |
| sg_init_table(sg, ret); |
| ret = skb_to_sgvec(skb, sg, 0, skb->len); |
| if (unlikely(ret < 0)) { |
| + aead_request_free(req); |
| kfree_skb(skb); |
| return ERR_PTR(ret); |
| } |
| -- |
| 2.17.1 |
| |
