| From d3defbed265453adbedb11d0b801d94114ca109a Mon Sep 17 00:00:00 2001 |
| From: Xin Long <lucien.xin@gmail.com> |
| Date: Sun, 26 Nov 2017 20:56:07 +0800 |
| Subject: sctp: use right member as the param of list_for_each_entry |
| |
| [ Upstream commit a8dd397903a6e57157f6265911f7d35681364427 ] |
| |
| Commit d04adf1b3551 ("sctp: reset owner sk for data chunks on out queues |
| when migrating a sock") made a mistake that using 'list' as the param of |
| list_for_each_entry to traverse the retransmit, sacked and abandoned |
| queues, while chunks are using 'transmitted_list' to link into these |
| queues. |
| |
| It could cause NULL dereference panic if there are chunks in any of these |
| queues when peeling off one asoc. |
| |
| So use the chunk member 'transmitted_list' instead in this patch. |
| |
| Fixes: d04adf1b3551 ("sctp: reset owner sk for data chunks on out queues when migrating a sock") |
| Signed-off-by: Xin Long <lucien.xin@gmail.com> |
| Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> |
| Acked-by: Neil Horman <nhorman@tuxdriver.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| net/sctp/socket.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| diff --git a/net/sctp/socket.c b/net/sctp/socket.c |
| index 64d2d9ea2f8c..16aa8673f918 100644 |
| --- a/net/sctp/socket.c |
| +++ b/net/sctp/socket.c |
| @@ -185,13 +185,13 @@ static void sctp_for_each_tx_datachunk(struct sctp_association *asoc, |
| list_for_each_entry(chunk, &t->transmitted, transmitted_list) |
| cb(chunk); |
| |
| - list_for_each_entry(chunk, &q->retransmit, list) |
| + list_for_each_entry(chunk, &q->retransmit, transmitted_list) |
| cb(chunk); |
| |
| - list_for_each_entry(chunk, &q->sacked, list) |
| + list_for_each_entry(chunk, &q->sacked, transmitted_list) |
| cb(chunk); |
| |
| - list_for_each_entry(chunk, &q->abandoned, list) |
| + list_for_each_entry(chunk, &q->abandoned, transmitted_list) |
| cb(chunk); |
| |
| list_for_each_entry(chunk, &q->out_chunk_list, list) |
| -- |
| 2.17.1 |
| |