| From a8845cfa6f488f4b8346795e5647b781806fcdba Mon Sep 17 00:00:00 2001 |
| From: Florian Fainelli <f.fainelli@gmail.com> |
| Date: Fri, 28 Sep 2018 16:18:56 -0700 |
| Subject: smsc95xx: Check for Wake-on-LAN modes |
| |
| [ Upstream commit c530c471ba37bdd9fe1c7185b01455c00ae606fb ] |
| |
| The driver does not check for Wake-on-LAN modes specified by an user, |
| but will conditionally set the device as wake-up enabled or not based on |
| that, which could be a very confusing user experience. |
| |
| Fixes: e0e474a83c18 ("smsc95xx: add wol magic packet support") |
| Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/usb/smsc95xx.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c |
| index 831aa33d078a..a167116ceeee 100644 |
| --- a/drivers/net/usb/smsc95xx.c |
| +++ b/drivers/net/usb/smsc95xx.c |
| @@ -775,6 +775,9 @@ static int smsc95xx_ethtool_set_wol(struct net_device *net, |
| struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]); |
| int ret; |
| |
| + if (wolinfo->wolopts & ~SUPPORTED_WAKE) |
| + return -EINVAL; |
| + |
| pdata->wolopts = wolinfo->wolopts & SUPPORTED_WAKE; |
| |
| ret = device_set_wakeup_enable(&dev->udev->dev, pdata->wolopts); |
| -- |
| 2.17.1 |
| |