| From e60a582bcde01158a64ff948fb799f21f5d31a11 Mon Sep 17 00:00:00 2001 |
| From: Arnd Bergmann <arnd@arndb.de> |
| Date: Thu, 7 Mar 2019 11:09:19 +0100 |
| Subject: mmc: pxamci: fix enum type confusion |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| commit e60a582bcde01158a64ff948fb799f21f5d31a11 upstream. |
| |
| clang points out several instances of mismatched types in this drivers, |
| all coming from a single declaration: |
| |
| drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enum dma_transfer_direction' to |
| different enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion] |
| direction = DMA_DEV_TO_MEM; |
| ~ ^~~~~~~~~~~~~~ |
| drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enum dma_data_direction' to |
| different enumeration type 'enum dma_transfer_direction' [-Werror,-Wenum-conversion] |
| tx = dmaengine_prep_slave_sg(chan, data->sg, host->dma_len, direction, |
| |
| The behavior is correct, so this must be a simply typo from |
| dma_data_direction and dma_transfer_direction being similarly named |
| types with a similar purpose. |
| |
| Fixes: 6464b7140951 ("mmc: pxamci: switch over to dmaengine use") |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> |
| Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/mmc/host/pxamci.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/mmc/host/pxamci.c |
| +++ b/drivers/mmc/host/pxamci.c |
| @@ -181,7 +181,7 @@ static void pxamci_dma_irq(void *param); |
| static void pxamci_setup_data(struct pxamci_host *host, struct mmc_data *data) |
| { |
| struct dma_async_tx_descriptor *tx; |
| - enum dma_data_direction direction; |
| + enum dma_transfer_direction direction; |
| struct dma_slave_config config; |
| struct dma_chan *chan; |
| unsigned int nob = data->blocks; |
