| From 0c671812f152b628bd87c0af49da032cc2a2c319 Mon Sep 17 00:00:00 2001 |
| From: Josh Poimboeuf <jpoimboe@redhat.com> |
| Date: Mon, 18 Mar 2019 19:09:38 -0500 |
| Subject: objtool: Move objtool_file struct off the stack |
| |
| From: Josh Poimboeuf <jpoimboe@redhat.com> |
| |
| commit 0c671812f152b628bd87c0af49da032cc2a2c319 upstream. |
| |
| Objtool uses over 512k of stack, thanks to the hash table embedded in |
| the objtool_file struct. This causes an unnecessarily large stack |
| allocation and breaks users with low stack limits. |
| |
| Move the struct off the stack. |
| |
| Fixes: 042ba73fe7eb ("objtool: Add several performance improvements") |
| Reported-by: Vassili Karpov <moosotc@gmail.com> |
| Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> |
| Signed-off-by: Thomas Gleixner <tglx@linutronix.de> |
| Cc: Peter Zijlstra <peterz@infradead.org> |
| Cc: stable@vger.kernel.org |
| Link: https://lkml.kernel.org/r/df92dcbc4b84b02ffa252f46876df125fb56e2d7.1552954176.git.jpoimboe@redhat.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| tools/objtool/check.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/tools/objtool/check.c |
| +++ b/tools/objtool/check.c |
| @@ -2132,9 +2132,10 @@ static void cleanup(struct objtool_file |
| elf_close(file->elf); |
| } |
| |
| +static struct objtool_file file; |
| + |
| int check(const char *_objname, bool orc) |
| { |
| - struct objtool_file file; |
| int ret, warnings = 0; |
| |
| objname = _objname; |
