| From foo@baz Tue 23 Jun 2020 09:03:02 PM CEST |
| From: Florian Fainelli <f.fainelli@gmail.com> |
| Date: Fri, 5 Jun 2020 09:25:05 -0700 |
| Subject: media: friio-fe: get rid of set_property() |
| To: linux-kernel@vger.kernel.org |
| Cc: stable@vger.kernel.org, Mauro Carvalho Chehab <mchehab@s-opensource.com>, Florian Fainelli <f.fainelli@gmail.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Michael Krufky <mkrufky@linuxtv.org>, Alexander Viro <viro@zeniv.linux.org.uk>, Shuah Khan <shuah@kernel.org>, Jaedon Shin <jaedon.shin@gmail.com>, Colin Ian King <colin.king@canonical.com>, Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>, Satendra Singh Thakur <satendra.t@samsung.com>, linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)), linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure)) |
| Message-ID: <20200605162518.28099-9-florian.fainelli@broadcom.com> |
| |
| From: Mauro Carvalho Chehab <mchehab@s-opensource.com> |
| |
| commit b2c41ca9632e686e79f6c9db9c5f75666d37926e upstream |
| |
| This callback is not actually doing anything but making it to |
| return an error depending on the DTV frontend command. Well, |
| that could break userspace for no good reason, and, if needed, |
| should be implemented, instead, at set_frontend() callback. |
| |
| So, get rid of it. |
| |
| Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> |
| Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/media/usb/dvb-usb/friio-fe.c | 24 ------------------------ |
| 1 file changed, 24 deletions(-) |
| |
| --- a/drivers/media/usb/dvb-usb/friio-fe.c |
| +++ b/drivers/media/usb/dvb-usb/friio-fe.c |
| @@ -261,28 +261,6 @@ static int jdvbt90502_read_signal_streng |
| return 0; |
| } |
| |
| - |
| -/* filter out un-supported properties to notify users */ |
| -static int jdvbt90502_set_property(struct dvb_frontend *fe, |
| - struct dtv_property *tvp) |
| -{ |
| - int r = 0; |
| - |
| - switch (tvp->cmd) { |
| - case DTV_DELIVERY_SYSTEM: |
| - if (tvp->u.data != SYS_ISDBT) |
| - r = -EINVAL; |
| - break; |
| - case DTV_CLEAR: |
| - case DTV_TUNE: |
| - case DTV_FREQUENCY: |
| - break; |
| - default: |
| - r = -EINVAL; |
| - } |
| - return r; |
| -} |
| - |
| static int jdvbt90502_set_frontend(struct dvb_frontend *fe) |
| { |
| struct dtv_frontend_properties *p = &fe->dtv_property_cache; |
| @@ -457,8 +435,6 @@ static struct dvb_frontend_ops jdvbt9050 |
| .init = jdvbt90502_init, |
| .write = _jdvbt90502_write, |
| |
| - .set_property = jdvbt90502_set_property, |
| - |
| .set_frontend = jdvbt90502_set_frontend, |
| |
| .read_status = jdvbt90502_read_status, |
