| From 0d9a808dc0a8bc0db7d6abf5bd586c5a15134dbf Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 23 Jul 2021 18:36:09 +0800 |
| Subject: mlx4: Fix missing error code in mlx4_load_one() |
| |
| From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> |
| |
| [ Upstream commit 7e4960b3d66d7248b23de3251118147812b42da2 ] |
| |
| The error code is missing in this code scenario, add the error code |
| '-EINVAL' to the return value 'err'. |
| |
| Eliminate the follow smatch warning: |
| |
| drivers/net/ethernet/mellanox/mlx4/main.c:3538 mlx4_load_one() warn: |
| missing error code 'err'. |
| |
| Reported-by: Abaci Robot <abaci@linux.alibaba.com> |
| Fixes: 7ae0e400cd93 ("net/mlx4_core: Flexible (asymmetric) allocation of EQs and MSI-X vectors for PF/VFs") |
| Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> |
| Reviewed-by: Tariq Toukan <tariqt@nvidia.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/mellanox/mlx4/main.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c |
| index 9b6a96074df8..78b04f271344 100644 |
| --- a/drivers/net/ethernet/mellanox/mlx4/main.c |
| +++ b/drivers/net/ethernet/mellanox/mlx4/main.c |
| @@ -3445,6 +3445,7 @@ slave_start: |
| |
| if (!SRIOV_VALID_STATE(dev->flags)) { |
| mlx4_err(dev, "Invalid SRIOV state\n"); |
| + err = -EINVAL; |
| goto err_close; |
| } |
| } |
| -- |
| 2.30.2 |
| |
