| From 34ff1bf4920471cff66775dc39537b15c5f0feff Mon Sep 17 00:00:00 2001 |
| From: Colin Ian King <colin.king@canonical.com> |
| Date: Fri, 18 Aug 2017 14:34:16 +0100 |
| Subject: staging/rts5208: fix incorrect shift to extract upper nybble |
| |
| From: Colin Ian King <colin.king@canonical.com> |
| |
| commit 34ff1bf4920471cff66775dc39537b15c5f0feff upstream. |
| |
| The mask of sns_key_info1 suggests the upper nybble is being extracted |
| however the following shift of 8 bits is too large and always results in |
| 0. Fix this by shifting only by 4 bits to correctly get the upper nybble. |
| |
| Detected by CoverityScan, CID#142891 ("Operands don't affect result") |
| |
| Fixes: fa590c222fba ("staging: rts5208: add support for rts5208 and rts5288") |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/staging/rts5208/rtsx_scsi.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/staging/rts5208/rtsx_scsi.c |
| +++ b/drivers/staging/rts5208/rtsx_scsi.c |
| @@ -414,7 +414,7 @@ void set_sense_data(struct rtsx_chip *ch |
| sense->ascq = ascq; |
| if (sns_key_info0 != 0) { |
| sense->sns_key_info[0] = SKSV | sns_key_info0; |
| - sense->sns_key_info[1] = (sns_key_info1 & 0xf0) >> 8; |
| + sense->sns_key_info[1] = (sns_key_info1 & 0xf0) >> 4; |
| sense->sns_key_info[2] = sns_key_info1 & 0x0f; |
| } |
| } |