| From foo@baz Thu Sep 14 23:20:08 PDT 2017 |
| From: Florian Fainelli <f.fainelli@gmail.com> |
| Date: Tue, 22 Aug 2017 15:24:47 -0700 |
| Subject: fsl/man: Inherit parent device and of_node |
| |
| From: Florian Fainelli <f.fainelli@gmail.com> |
| |
| |
| [ Upstream commit a1a50c8e4c241a505b7270e1a3c6e50d94e794b1 ] |
| |
| Junote Cai reported that he was not able to get a DSA setup involving the |
| Freescale DPAA/FMAN driver to work and narrowed it down to |
| of_find_net_device_by_node(). This function requires the network device's |
| device reference to be correctly set which is the case here, though we have |
| lost any device_node association there. |
| |
| The problem is that dpaa_eth_add_device() allocates a "dpaa-ethernet" platform |
| device, and later on dpaa_eth_probe() is called but SET_NETDEV_DEV() won't be |
| propagating &pdev->dev.of_node properly. Fix this by inherenting both the parent |
| device and the of_node when dpaa_eth_add_device() creates the platform device. |
| |
| Fixes: 3933961682a3 ("fsl/fman: Add FMan MAC driver") |
| Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/freescale/fman/mac.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| --- a/drivers/net/ethernet/freescale/fman/mac.c |
| +++ b/drivers/net/ethernet/freescale/fman/mac.c |
| @@ -622,6 +622,9 @@ static struct platform_device *dpaa_eth_ |
| goto no_mem; |
| } |
| |
| + pdev->dev.of_node = node; |
| + pdev->dev.parent = priv->dev; |
| + |
| ret = platform_device_add_data(pdev, &data, sizeof(data)); |
| if (ret) |
| goto err; |