| From 9a3bc639f96b98b7787e5a495a0be61bcb046b1b Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 29 Jul 2021 17:12:46 +0300 |
| Subject: can: hi311x: fix a signedness bug in hi3110_cmd() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit f6b3c7848e66e9046c8a79a5b88fd03461cc252b ] |
| |
| The hi3110_cmd() is supposed to return zero on success and negative |
| error codes on failure, but it was accidentally declared as a u8 when |
| it needs to be an int type. |
| |
| Fixes: 57e83fb9b746 ("can: hi311x: Add Holt HI-311x CAN driver") |
| Link: https://lore.kernel.org/r/20210729141246.GA1267@kili |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/can/spi/hi311x.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/can/spi/hi311x.c b/drivers/net/can/spi/hi311x.c |
| index 73d48c3b8ded..7d2315c8cacb 100644 |
| --- a/drivers/net/can/spi/hi311x.c |
| +++ b/drivers/net/can/spi/hi311x.c |
| @@ -218,7 +218,7 @@ static int hi3110_spi_trans(struct spi_device *spi, int len) |
| return ret; |
| } |
| |
| -static u8 hi3110_cmd(struct spi_device *spi, u8 command) |
| +static int hi3110_cmd(struct spi_device *spi, u8 command) |
| { |
| struct hi3110_priv *priv = spi_get_drvdata(spi); |
| |
| -- |
| 2.30.2 |
| |
