| From e0eef3690dc66b3ecc6e0f1267f332403eb22bea Mon Sep 17 00:00:00 2001 |
| From: Hui Wang <hui.wang@canonical.com> |
| Date: Wed, 28 Jul 2021 23:19:58 +0800 |
| Subject: Revert "ACPI: resources: Add checks for ACPI IRQ override" |
| |
| From: Hui Wang <hui.wang@canonical.com> |
| |
| commit e0eef3690dc66b3ecc6e0f1267f332403eb22bea upstream. |
| |
| The commit 0ec4e55e9f57 ("ACPI: resources: Add checks for ACPI IRQ |
| override") introduces regression on some platforms, at least it makes |
| the UART can't get correct irq setting on two different platforms, |
| and it makes the kernel can't bootup on these two platforms. |
| |
| This reverts commit 0ec4e55e9f571f08970ed115ec0addc691eda613. |
| |
| Regression-discuss: https://bugzilla.kernel.org/show_bug.cgi?id=213031 |
| Reported-by: PGNd <pgnet.dev@gmail.com> |
| Cc: 5.4+ <stable@vger.kernel.org> # 5.4+ |
| Signed-off-by: Hui Wang <hui.wang@canonical.com> |
| Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/acpi/resource.c | 9 +-------- |
| 1 file changed, 1 insertion(+), 8 deletions(-) |
| |
| --- a/drivers/acpi/resource.c |
| +++ b/drivers/acpi/resource.c |
| @@ -430,13 +430,6 @@ static void acpi_dev_get_irqresource(str |
| } |
| } |
| |
| -static bool irq_is_legacy(struct acpi_resource_irq *irq) |
| -{ |
| - return irq->triggering == ACPI_EDGE_SENSITIVE && |
| - irq->polarity == ACPI_ACTIVE_HIGH && |
| - irq->shareable == ACPI_EXCLUSIVE; |
| -} |
| - |
| /** |
| * acpi_dev_resource_interrupt - Extract ACPI interrupt resource information. |
| * @ares: Input ACPI resource object. |
| @@ -475,7 +468,7 @@ bool acpi_dev_resource_interrupt(struct |
| } |
| acpi_dev_get_irqresource(res, irq->interrupts[index], |
| irq->triggering, irq->polarity, |
| - irq->shareable, irq_is_legacy(irq)); |
| + irq->shareable, true); |
| break; |
| case ACPI_RESOURCE_TYPE_EXTENDED_IRQ: |
| ext_irq = &ares->data.extended_irq; |