| From 64b50ed5db670ccfd3422e71ee00868ec3da8e06 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 27 Jul 2021 23:40:54 -0300 |
| Subject: sctp: fix return value check in __sctp_rcv_asconf_lookup |
| |
| From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> |
| |
| [ Upstream commit 557fb5862c9272ad9b21407afe1da8acfd9b53eb ] |
| |
| As Ben Hutchings noticed, this check should have been inverted: the call |
| returns true in case of success. |
| |
| Reported-by: Ben Hutchings <ben@decadent.org.uk> |
| Fixes: 0c5dc070ff3d ("sctp: validate from_addr_param return") |
| Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> |
| Reviewed-by: Xin Long <lucien.xin@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| net/sctp/input.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/net/sctp/input.c b/net/sctp/input.c |
| index f72bff93745c..ddb5b5c2550e 100644 |
| --- a/net/sctp/input.c |
| +++ b/net/sctp/input.c |
| @@ -1175,7 +1175,7 @@ static struct sctp_association *__sctp_rcv_asconf_lookup( |
| if (unlikely(!af)) |
| return NULL; |
| |
| - if (af->from_addr_param(&paddr, param, peer_port, 0)) |
| + if (!af->from_addr_param(&paddr, param, peer_port, 0)) |
| return NULL; |
| |
| return __sctp_lookup_association(net, laddr, &paddr, transportp); |
| -- |
| 2.30.2 |
| |
