| From 376a1a33aa2fe119ff72a42d9ab4181d950979e1 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 11 Sep 2021 15:50:22 +0800 |
| Subject: drm/nouveau/kms/nv50-: fix file release memory leak |
| |
| From: Yang Yingliang <yangyingliang@huawei.com> |
| |
| [ Upstream commit 0b3d4945cc7e7ea1acd52cb06dfa83bfe265b6d5 ] |
| |
| When using single_open() for opening, single_release() should be |
| called, otherwise the 'op' allocated in single_open() will be leaked. |
| |
| Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> |
| Reviewed-by: Karol Herbst <kherbst@redhat.com> |
| Signed-off-by: Karol Herbst <kherbst@redhat.com> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20210911075023.3969054-1-yangyingliang@huawei.com |
| Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/nouveau/dispnv50/crc.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c |
| index b8c31b697797..66f32d965c72 100644 |
| --- a/drivers/gpu/drm/nouveau/dispnv50/crc.c |
| +++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c |
| @@ -704,6 +704,7 @@ static const struct file_operations nv50_crc_flip_threshold_fops = { |
| .open = nv50_crc_debugfs_flip_threshold_open, |
| .read = seq_read, |
| .write = nv50_crc_debugfs_flip_threshold_set, |
| + .release = single_release, |
| }; |
| |
| int nv50_head_crc_late_register(struct nv50_head *head) |
| -- |
| 2.33.0 |
| |
