| From b38041d50add1c881fbc60eb2be93b58fc58ea21 Mon Sep 17 00:00:00 2001 |
| From: Jack Wang <jinpu.wang@cloud.ionos.com> |
| Date: Thu, 17 Dec 2020 15:19:11 +0100 |
| Subject: RDMA/rtrs: Do not signal for heatbeat |
| |
| From: Jack Wang <jinpu.wang@cloud.ionos.com> |
| |
| commit b38041d50add1c881fbc60eb2be93b58fc58ea21 upstream. |
| |
| For HB, there is no need to generate signal for completion. |
| |
| Also remove a comment accordingly. |
| |
| Fixes: c0894b3ea69d ("RDMA/rtrs: core: lib functions shared between client and server modules") |
| Link: https://lore.kernel.org/r/20201217141915.56989-16-jinpu.wang@cloud.ionos.com |
| Signed-off-by: Jack Wang <jinpu.wang@cloud.ionos.com> |
| Reported-by: Gioh Kim <gi-oh.kim@cloud.ionos.com> |
| Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 - |
| drivers/infiniband/ulp/rtrs/rtrs-srv.c | 1 - |
| drivers/infiniband/ulp/rtrs/rtrs.c | 4 ++-- |
| 3 files changed, 2 insertions(+), 4 deletions(-) |
| |
| --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c |
| +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c |
| @@ -666,7 +666,6 @@ static void rtrs_clt_rdma_done(struct ib |
| case IB_WC_RDMA_WRITE: |
| /* |
| * post_send() RDMA write completions of IO reqs (read/write) |
| - * and hb |
| */ |
| break; |
| |
| --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c |
| +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c |
| @@ -1244,7 +1244,6 @@ static void rtrs_srv_rdma_done(struct ib |
| case IB_WC_SEND: |
| /* |
| * post_send() RDMA write completions of IO reqs (read/write) |
| - * and hb |
| */ |
| atomic_add(srv->queue_depth, &con->sq_wr_avail); |
| |
| --- a/drivers/infiniband/ulp/rtrs/rtrs.c |
| +++ b/drivers/infiniband/ulp/rtrs/rtrs.c |
| @@ -310,7 +310,7 @@ void rtrs_send_hb_ack(struct rtrs_sess * |
| |
| imm = rtrs_to_imm(RTRS_HB_ACK_IMM, 0); |
| err = rtrs_post_rdma_write_imm_empty(usr_con, sess->hb_cqe, imm, |
| - IB_SEND_SIGNALED, NULL); |
| + 0, NULL); |
| if (err) { |
| sess->hb_err_handler(usr_con); |
| return; |
| @@ -339,7 +339,7 @@ static void hb_work(struct work_struct * |
| } |
| imm = rtrs_to_imm(RTRS_HB_MSG_IMM, 0); |
| err = rtrs_post_rdma_write_imm_empty(usr_con, sess->hb_cqe, imm, |
| - IB_SEND_SIGNALED, NULL); |
| + 0, NULL); |
| if (err) { |
| sess->hb_err_handler(usr_con); |
| return; |