| From 0704cadc0a94eab75c62d512527546e9b25208a4 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 30 Jun 2021 17:23:16 +0200 |
| Subject: ACPI: video: Add quirk for the Dell Vostro 3350 |
| |
| From: Hans de Goede <hdegoede@redhat.com> |
| |
| [ Upstream commit 9249c32ec9197e8d34fe5179c9e31668a205db04 ] |
| |
| The Dell Vostro 3350 ACPI video-bus device reports spurious |
| ACPI_VIDEO_NOTIFY_CYCLE events resulting in spurious KEY_SWITCHVIDEOMODE |
| events being reported to userspace (and causing trouble there). |
| |
| Add a quirk setting the report_key_events mask to |
| REPORT_BRIGHTNESS_KEY_EVENTS so that the ACPI_VIDEO_NOTIFY_CYCLE |
| events will be ignored, while still reporting brightness up/down |
| hotkey-presses to userspace normally. |
| |
| BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1911763 |
| Signed-off-by: Hans de Goede <hdegoede@redhat.com> |
| Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/acpi/acpi_video.c | 9 +++++++++ |
| 1 file changed, 9 insertions(+) |
| |
| diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c |
| index 2ea1781290cc..1b68d116d808 100644 |
| --- a/drivers/acpi/acpi_video.c |
| +++ b/drivers/acpi/acpi_video.c |
| @@ -540,6 +540,15 @@ static const struct dmi_system_id video_dmi_table[] = { |
| DMI_MATCH(DMI_PRODUCT_NAME, "Vostro V131"), |
| }, |
| }, |
| + { |
| + .callback = video_set_report_key_events, |
| + .driver_data = (void *)((uintptr_t)REPORT_BRIGHTNESS_KEY_EVENTS), |
| + .ident = "Dell Vostro 3350", |
| + .matches = { |
| + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), |
| + DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3350"), |
| + }, |
| + }, |
| /* |
| * Some machines change the brightness themselves when a brightness |
| * hotkey gets pressed, despite us telling them not to. In this case |
| -- |
| 2.30.2 |
| |