| From 885d82c94516c306df830080144f227f6322df18 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 25 Apr 2021 19:49:45 +0200 |
| Subject: ARM: exynos: add missing of_node_put for loop iteration |
| |
| From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> |
| |
| [ Upstream commit 48d551bf20858240f38a0276be3016ff379918ac ] |
| |
| Early exits from for_each_compatible_node() should decrement the |
| node reference counter. Reported by Coccinelle: |
| |
| arch/arm/mach-exynos/exynos.c:52:1-25: WARNING: |
| Function "for_each_compatible_node" should have of_node_put() before break around line 58. |
| |
| Fixes: b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT bindings") |
| Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> |
| Acked-by: Arnd Bergmann <arnd@arndb.de> |
| Link: https://lore.kernel.org/r/20210425174945.164612-1-krzysztof.kozlowski@canonical.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/arm/mach-exynos/exynos.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c |
| index 25b01da4771b..8b48326be9fd 100644 |
| --- a/arch/arm/mach-exynos/exynos.c |
| +++ b/arch/arm/mach-exynos/exynos.c |
| @@ -55,6 +55,7 @@ void __init exynos_sysram_init(void) |
| sysram_base_addr = of_iomap(node, 0); |
| sysram_base_phys = of_translate_address(node, |
| of_get_address(node, 0, NULL, NULL)); |
| + of_node_put(node); |
| break; |
| } |
| |
| @@ -62,6 +63,7 @@ void __init exynos_sysram_init(void) |
| if (!of_device_is_available(node)) |
| continue; |
| sysram_ns_base_addr = of_iomap(node, 0); |
| + of_node_put(node); |
| break; |
| } |
| } |
| -- |
| 2.30.2 |
| |