| From 9cc1a939c9c014be66961cf7e35d143bbe948e80 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 14 Jun 2021 09:17:46 +0200 |
| Subject: ASoC: soc-pcm: fix the return value in dpcm_apply_symmetry() |
| |
| From: Jaroslav Kysela <perex@perex.cz> |
| |
| [ Upstream commit 12ffd726824a2f52486f72338b6fd3244b512959 ] |
| |
| In case, where the loops are not executed for a reason, the uninitialized |
| variable 'err' is returned to the caller. Make code fully predictible |
| and assign zero in the declaration. |
| |
| Signed-off-by: Jaroslav Kysela <perex@perex.cz> |
| Cc: Mark Brown <broonie@kernel.org> |
| Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> |
| Link: https://lore.kernel.org/r/20210614071746.1787072-1-perex@perex.cz |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/soc/soc-pcm.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c |
| index 14d85ca1e435..4a25a1e39831 100644 |
| --- a/sound/soc/soc-pcm.c |
| +++ b/sound/soc/soc-pcm.c |
| @@ -1695,7 +1695,7 @@ static int dpcm_apply_symmetry(struct snd_pcm_substream *fe_substream, |
| struct snd_soc_dpcm *dpcm; |
| struct snd_soc_pcm_runtime *fe = asoc_substream_to_rtd(fe_substream); |
| struct snd_soc_dai *fe_cpu_dai; |
| - int err; |
| + int err = 0; |
| int i; |
| |
| /* apply symmetry for FE */ |
| -- |
| 2.30.2 |
| |
