| From 6fc51f00142f7a0f491ac41edf652839614eb19f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 13 May 2021 21:26:46 +0800 |
| Subject: firmware: tegra: Fix error return code in tegra210_bpmp_init() |
| |
| From: Zhen Lei <thunder.leizhen@huawei.com> |
| |
| [ Upstream commit 7fea67710e9f6a111a2c9440576f2396ccd92d57 ] |
| |
| When call irq_get_irq_data() to get the IRQ's irq_data failed, an |
| appropriate error code -ENOENT should be returned. However, we directly |
| return 'err', which records the IRQ number instead of the error code. |
| |
| Fixes: 139251fc2208 ("firmware: tegra: add bpmp driver for Tegra210") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> |
| Signed-off-by: Thierry Reding <treding@nvidia.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/firmware/tegra/bpmp-tegra210.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/firmware/tegra/bpmp-tegra210.c b/drivers/firmware/tegra/bpmp-tegra210.c |
| index ae15940a078e..c32754055c60 100644 |
| --- a/drivers/firmware/tegra/bpmp-tegra210.c |
| +++ b/drivers/firmware/tegra/bpmp-tegra210.c |
| @@ -210,7 +210,7 @@ static int tegra210_bpmp_init(struct tegra_bpmp *bpmp) |
| priv->tx_irq_data = irq_get_irq_data(err); |
| if (!priv->tx_irq_data) { |
| dev_err(&pdev->dev, "failed to get IRQ data for TX IRQ\n"); |
| - return err; |
| + return -ENOENT; |
| } |
| |
| err = platform_get_irq_byname(pdev, "rx"); |
| -- |
| 2.30.2 |
| |
