| From 157973d9677472700d9f2b654ad980be9b88a01a Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 10 Jun 2021 09:14:43 +0300 |
| Subject: habanalabs/gaudi: set the correct rc in case of err |
| |
| From: Koby Elbaz <kelbaz@habana.ai> |
| |
| [ Upstream commit 1f7ef4bf41c7c2abad3d21b8c69db11fc3ebc4f5 ] |
| |
| fix the following smatch warnings: |
| gaudi_internal_cb_pool_init() warn: missing error code 'rc' |
| |
| Signed-off-by: Koby Elbaz <kelbaz@habana.ai> |
| Reviewed-by: Oded Gabbay <ogabbay@kernel.org> |
| Signed-off-by: Oded Gabbay <ogabbay@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/misc/habanalabs/gaudi/gaudi.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c |
| index 0c6092ebbc04..894056da22cf 100644 |
| --- a/drivers/misc/habanalabs/gaudi/gaudi.c |
| +++ b/drivers/misc/habanalabs/gaudi/gaudi.c |
| @@ -8070,8 +8070,10 @@ static int gaudi_internal_cb_pool_init(struct hl_device *hdev, |
| HL_VA_RANGE_TYPE_HOST, HOST_SPACE_INTERNAL_CB_SZ, |
| HL_MMU_VA_ALIGNMENT_NOT_NEEDED); |
| |
| - if (!hdev->internal_cb_va_base) |
| + if (!hdev->internal_cb_va_base) { |
| + rc = -ENOMEM; |
| goto destroy_internal_cb_pool; |
| + } |
| |
| mutex_lock(&ctx->mmu_lock); |
| rc = hl_mmu_map_contiguous(ctx, hdev->internal_cb_va_base, |
| -- |
| 2.30.2 |
| |