| From 9c6882608bce249a8918744ecdb65748534e3f17 Mon Sep 17 00:00:00 2001 |
| From: Pavel Begunkov <asml.silence@gmail.com> |
| Date: Sat, 10 Jul 2021 02:45:59 +0100 |
| Subject: io_uring: use right task for exiting checks |
| |
| From: Pavel Begunkov <asml.silence@gmail.com> |
| |
| commit 9c6882608bce249a8918744ecdb65748534e3f17 upstream. |
| |
| When we use delayed_work for fallback execution of requests, current |
| will be not of the submitter task, and so checks in io_req_task_submit() |
| may not behave as expected. Currently, it leaves inline completions not |
| flushed, so making io_ring_exit_work() to hang. Use the submitter task |
| for all those checks. |
| |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> |
| Link: https://lore.kernel.org/r/cb413c715bed0bc9c98b169059ea9c8a2c770715.1625881431.git.asml.silence@gmail.com |
| Signed-off-by: Jens Axboe <axboe@kernel.dk> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| fs/io_uring.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/io_uring.c |
| +++ b/fs/io_uring.c |
| @@ -2023,7 +2023,7 @@ static void __io_req_task_submit(struct |
| |
| /* ctx stays valid until unlock, even if we drop all ours ctx->refs */ |
| mutex_lock(&ctx->uring_lock); |
| - if (!(current->flags & PF_EXITING) && !current->in_execve) |
| + if (!(req->task->flags & PF_EXITING) && !req->task->in_execve) |
| __io_queue_sqe(req); |
| else |
| __io_req_task_cancel(req, -EFAULT); |
