| From cb359f6c865378a2da48b5279ae30d6727fa10d7 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 15 May 2021 12:00:04 +0800 |
| Subject: memory: pl353: Fix error return code in pl353_smc_probe() |
| |
| From: Zhen Lei <thunder.leizhen@huawei.com> |
| |
| [ Upstream commit 76e5624f3f9343a621dd3f4006f4e4d9c3f91e33 ] |
| |
| When no child nodes are matched, an appropriate error code -ENODEV should |
| be returned. However, we currently do not explicitly assign this error |
| code to 'err'. As a result, 0 was incorrectly returned. |
| |
| Fixes: fee10bd22678 ("memory: pl353: Add driver for arm pl353 static memory controller") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> |
| Link: https://lore.kernel.org/r/20210515040004.6983-1-thunder.leizhen@huawei.com |
| Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/memory/pl353-smc.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/memory/pl353-smc.c b/drivers/memory/pl353-smc.c |
| index 9c0a28416777..b0b251bb207f 100644 |
| --- a/drivers/memory/pl353-smc.c |
| +++ b/drivers/memory/pl353-smc.c |
| @@ -407,6 +407,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id) |
| break; |
| } |
| if (!match) { |
| + err = -ENODEV; |
| dev_err(&adev->dev, "no matching children\n"); |
| goto out_clk_disable; |
| } |
| -- |
| 2.30.2 |
| |
