| From 4db9db208806057396051a6d6dbe40273fa8c955 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 12 May 2021 11:57:17 +0800 |
| Subject: pwm: img: Fix PM reference leak in img_pwm_enable() |
| |
| From: Zou Wei <zou_wei@huawei.com> |
| |
| [ Upstream commit fde25294dfd8e36e4e30b693c27a86232864002a ] |
| |
| pm_runtime_get_sync will increment pm usage counter even it failed. |
| Forgetting to putting operation will result in reference leak here. |
| Fix it by replacing it with pm_runtime_resume_and_get to keep usage |
| counter balanced. |
| |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Zou Wei <zou_wei@huawei.com> |
| Signed-off-by: Thierry Reding <thierry.reding@gmail.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pwm/pwm-img.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/pwm/pwm-img.c b/drivers/pwm/pwm-img.c |
| index 6faf5b5a5584..37200850cdc6 100644 |
| --- a/drivers/pwm/pwm-img.c |
| +++ b/drivers/pwm/pwm-img.c |
| @@ -156,7 +156,7 @@ static int img_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) |
| struct img_pwm_chip *pwm_chip = to_img_pwm_chip(chip); |
| int ret; |
| |
| - ret = pm_runtime_get_sync(chip->dev); |
| + ret = pm_runtime_resume_and_get(chip->dev); |
| if (ret < 0) |
| return ret; |
| |
| -- |
| 2.30.2 |
| |
