| From a4623294c1e855c806d769f1dffff35b24976fc3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 25 May 2021 08:35:27 +0200 |
| Subject: pwm: imx1: Don't disable clocks at device remove time |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
| |
| [ Upstream commit 1bc6ea31cb41d50302a3c9b401964cf0a88d41f9 ] |
| |
| The .remove() callback disables clocks that were not enabled in |
| .probe(). So just probing and then unbinding the driver results in a clk |
| enable imbalance. |
| |
| So just drop the call to disable the clocks. (Which BTW was also in the |
| wrong order because the call makes the PWM unfunctional and so should |
| have come only after pwmchip_remove()). |
| |
| Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation") |
| Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
| Signed-off-by: Thierry Reding <thierry.reding@gmail.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pwm/pwm-imx1.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| diff --git a/drivers/pwm/pwm-imx1.c b/drivers/pwm/pwm-imx1.c |
| index 727e0d3e249e..cd48136e5a53 100644 |
| --- a/drivers/pwm/pwm-imx1.c |
| +++ b/drivers/pwm/pwm-imx1.c |
| @@ -169,8 +169,6 @@ static int pwm_imx1_remove(struct platform_device *pdev) |
| { |
| struct pwm_imx1_chip *imx = platform_get_drvdata(pdev); |
| |
| - pwm_imx1_clk_disable_unprepare(&imx->chip); |
| - |
| return pwmchip_remove(&imx->chip); |
| } |
| |
| -- |
| 2.30.2 |
| |
