| From 80927822e8b6be46f488524cd7d5fe683de97fc4 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Thu, 3 Jun 2021 15:33:20 +0300 |
| Subject: scsi: scsi_dh_alua: Fix signedness bug in alua_rtpg() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit 80927822e8b6be46f488524cd7d5fe683de97fc4 upstream. |
| |
| The "retval" variable needs to be signed for the error handling to work. |
| |
| Link: https://lore.kernel.org/r/YLjMEAFNxOas1mIp@mwanda |
| Fixes: 7e26e3ea0287 ("scsi: scsi_dh_alua: Check for negative result value") |
| Reviewed-by: Martin Wilck <mwilck@suse.com> |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/scsi/device_handler/scsi_dh_alua.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/scsi/device_handler/scsi_dh_alua.c |
| +++ b/drivers/scsi/device_handler/scsi_dh_alua.c |
| @@ -516,7 +516,8 @@ static int alua_rtpg(struct scsi_device |
| struct alua_port_group *tmp_pg; |
| int len, k, off, bufflen = ALUA_RTPG_SIZE; |
| unsigned char *desc, *buff; |
| - unsigned err, retval; |
| + unsigned err; |
| + int retval; |
| unsigned int tpg_desc_tbl_off; |
| unsigned char orig_transition_tmo; |
| unsigned long flags; |
