| From 8b3bdd99c092bbaeaa7d9eecb1a3e5dc9112002b Mon Sep 17 00:00:00 2001 |
| From: Steffen Maier <maier@linux.ibm.com> |
| Date: Fri, 2 Jul 2021 18:09:22 +0200 |
| Subject: scsi: zfcp: Report port fc_security as unknown early during remote cable pull |
| |
| From: Steffen Maier <maier@linux.ibm.com> |
| |
| commit 8b3bdd99c092bbaeaa7d9eecb1a3e5dc9112002b upstream. |
| |
| On remote cable pull, a zfcp_port keeps its status and only gets |
| ZFCP_STATUS_PORT_LINK_TEST added. Only after an ADISC timeout, we would |
| actually start port recovery and remove ZFCP_STATUS_COMMON_UNBLOCKED which |
| zfcp_sysfs_port_fc_security_show() detected and reported as "unknown" |
| instead of the old and possibly stale zfcp_port->connection_info. |
| |
| Add check for ZFCP_STATUS_PORT_LINK_TEST for timely "unknown" report. |
| |
| Link: https://lore.kernel.org/r/20210702160922.2667874-1-maier@linux.ibm.com |
| Fixes: a17c78460093 ("scsi: zfcp: report FC Endpoint Security in sysfs") |
| Cc: <stable@vger.kernel.org> #5.7+ |
| Reviewed-by: Benjamin Block <bblock@linux.ibm.com> |
| Signed-off-by: Steffen Maier <maier@linux.ibm.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/s390/scsi/zfcp_sysfs.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/s390/scsi/zfcp_sysfs.c |
| +++ b/drivers/s390/scsi/zfcp_sysfs.c |
| @@ -487,6 +487,7 @@ static ssize_t zfcp_sysfs_port_fc_securi |
| if (0 == (status & ZFCP_STATUS_COMMON_OPEN) || |
| 0 == (status & ZFCP_STATUS_COMMON_UNBLOCKED) || |
| 0 == (status & ZFCP_STATUS_PORT_PHYS_OPEN) || |
| + 0 != (status & ZFCP_STATUS_PORT_LINK_TEST) || |
| 0 != (status & ZFCP_STATUS_COMMON_ERP_FAILED) || |
| 0 != (status & ZFCP_STATUS_COMMON_ACCESS_BOXED)) |
| i = sprintf(buf, "unknown\n"); |
