| From 05dbd072f4a68916cb336749c228a568c95e044b Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 25 May 2021 09:51:42 -0400 |
| Subject: selftests/powerpc: Fix "no_handler" EBB selftest |
| |
| From: Athira Rajeev <atrajeev@linux.vnet.ibm.com> |
| |
| [ Upstream commit 45677c9aebe926192e59475b35a1ff35ff2d4217 ] |
| |
| The "no_handler_test" in ebb selftests attempts to read the PMU |
| registers twice via helper function "dump_ebb_state". First dump is |
| just before closing of event and the second invocation is done after |
| closing of the event. The original intention of second |
| dump_ebb_state was to dump the state of registers at the end of |
| the test when the counters are frozen. But this will be achieved |
| with the first call itself since sample period is set to low value |
| and PMU will be frozen by then. Hence patch removes the |
| dump which was done before closing of the event. |
| |
| Reported-by: Shirisha Ganta <shirisha.ganta1@ibm.com> |
| Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> |
| Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com <mailto:rnsastry@linux.ibm.com>> |
| Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> |
| Link: https://lore.kernel.org/r/1621950703-1532-2-git-send-email-atrajeev@linux.vnet.ibm.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/testing/selftests/powerpc/pmu/ebb/no_handler_test.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| diff --git a/tools/testing/selftests/powerpc/pmu/ebb/no_handler_test.c b/tools/testing/selftests/powerpc/pmu/ebb/no_handler_test.c |
| index fc5bf4870d8e..01e827c31169 100644 |
| --- a/tools/testing/selftests/powerpc/pmu/ebb/no_handler_test.c |
| +++ b/tools/testing/selftests/powerpc/pmu/ebb/no_handler_test.c |
| @@ -50,8 +50,6 @@ static int no_handler_test(void) |
| |
| event_close(&event); |
| |
| - dump_ebb_state(); |
| - |
| /* The real test is that we never took an EBB at 0x0 */ |
| |
| return 0; |
| -- |
| 2.30.2 |
| |